Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct cavefish atlas age #253

Merged
merged 2 commits into from
Oct 14, 2024
Merged

correct cavefish atlas age #253

merged 2 commits into from
Oct 14, 2024

Conversation

alessandrofelder
Copy link
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

Cavefish age was wrong on website, reported by @Robkozol on zulip.

What does this PR do?
Corrects the age of the cavefish atlas listed on the website.

@alessandrofelder alessandrofelder requested a review from a team October 14, 2024 11:10
niksirbi
niksirbi approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@niksirbi niksirbi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just observing that in the Max Planck zebra fish atlas, "days post fertilization" is abbreviated as "dpf". We should be consistent about whether to use abbreviations. My personal preference would be to not abbreviate this one.

@alessandrofelder alessandrofelder merged commit 8f3dd12 into main Oct 14, 2024
3 checks passed
@alessandrofelder alessandrofelder deleted the correct-cavefish-age branch October 14, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niksirbi niksirbi niksirbi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessandrofelder @niksirbi